deps.ffmpeg: Update SVT-AV1 to 3.0.0 #278
Open
+5
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVT-AV1 3.0.0 no longer vendors cpuinfo. They now use CMake's
FetchContent by default, unless we specify at configure time to use an
external copy. This means that we cannot Patch cpuinfo before Configure.
If we determine that the patch is no longer required, then we can simply
remove it.
If we determine that the patch is still required, then we have to
either:
A. upstream our patch, then get SVT-AV1 to update the commit they use
for FetchContent
B. figure out if we can use a SYSTEM/EXTERNAL cpuinfo
C. disable cpuinfo (USE_CPUINFO=OFF)
|
It looks like FFmpeg 7.1 doesn't support SVT-AV1 3.0.0, so this will have to wait for a future update. However, my questions about our cpuinfo patch remain, and we should probably think about those in advance. |
|
Apparently SVT-AV1 have no "deprecation then replace" process to prepare for some kind of API/ABI breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update SVT-AV1 to 3.0.0.
SVT-AV1 3.0.0 no longer vendors cpuinfo (see SVT-AV1 release notes and the commit in question). They now use CMake's FetchContent by default, unless we specify at configure time to use an external copy. This means that we cannot Patch cpuinfo before Configure.
If we determine that the patch is no longer required, then we can simply remove it.
If we determine that the patch is still required, then we have to either:
A. upstream our patch, then get SVT-AV1 to update the commit they use
for FetchContent
B. figure out if we can use a SYSTEM/EXTERNAL cpuinfo
C. disable cpuinfo (USE_CPUINFO=OFF)
Motivation and Context
Want to explore keeping dependencies up to date while managing our patches.
How Has This Been Tested?
Built locally on Windows 11, and I think I built OBS Studio against that though I do not have clear notes on it. I'd like further review to try to understand what choices we have for dealing with the new cpuinfo changes.
Types of changes
Checklist: