Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget: Fix winget meson installation #281

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Mar 3, 2025

Description

Fix winget meson installation. Without this change, meson will not be installed automatically via winget. Can change the first commit prefix to utils.pwsh if preferred, since it also modifies a file there.

A second commit changes the syntax for .Wingetfile so that it is uniform for all entries.

Motivation and Context

Pointed out on #277. Further investigation showed that this does indeed fail if meson cannot be found with Get-Command.

How Has This Been Tested?

Tested locally on Windows 11.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested a review from PatTheMav March 3, 2025 22:47
@RytoEX RytoEX self-assigned this Mar 3, 2025
@RytoEX
Copy link
Member Author

RytoEX commented Mar 3, 2025

Hmm. Odd that the WoA builds failed with this change. Will have to investigate further.

RytoEX added 2 commits March 3, 2025 18:45
Without this change, meson will not be installed automatically.

Also update meson package check on CI.
Always use a colon after the label.
@RytoEX RytoEX force-pushed the fix-winget-meson-id branch from 79abce9 to 36462d4 Compare March 3, 2025 23:46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntactically it should still be package <id>[, path: <path>[, bin: <binary>]], as the package keyword starts a package declaration, whereas path or bin are attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants