-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtmp-services: Add multitrack video configuration support #10543
rtmp-services: Add multitrack video configuration support #10543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious about the locale string here and if we can remove the service-specific one. No other notes/nits at this time.
Also would echo the sentiment that calling it |
Th PR title is misleading and I think some of the comments on the code. While the intention may be to add configure multitrack video, this PR and the code in only implements setting a custom configuration URL for an RTMP provider . Currently these seems locked to twitch and only configuring multitrack video but, if merged, I think this should be generalized (and "standarized") so it doesn't mention twitch and we allow to configure other stuff different than multitrack video. |
d76bdbf
to
4e781fc
Compare
ec37d8f
to
59c7325
Compare
One of these days we'll have to work on that big service update to make things easier for services to share features as well as to make things easier for individual services to customize (and get that RFC through), but this has my approval |
I've adjusted the PR title. Twitch is contributing the code, so it aligns with their implementation. That said, there is nothing stopping other platforms/providers from implementing this. See Twitch's Help Article on Multiple Encodes, specifically:
None of the actual code mentions Twitch anymore. The only places that do are examples in the JSON schema and the strings in the services.json file in Twitch's entry, where they are appropriate. @palana Please squash the commits here. |
59c7325
to
14602a6
Compare
@palana Please see @Warchamp7 's review comment on #10634. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message nit:
rtmp-services: Allow loading Multitrack Video configuration from services.json
This commit message subject is too long.
Instead, use this:
rtmp-services: Allow loading Multitrack Video config from JSON
Add support for loading Multitrack Video configuration data from
services.json.
Add support for loading Multitrack Video configuration data from services.json.
0e61f3f
to
daf5e65
Compare
@RytoEX: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
These changes are prerequisites for the upcoming multitrack video/Enhanced Broadcasting support, and add support for eRTMP multitrack video configuration URL (and related disclaimers) to
rtmp-services
(andlibobs
)Motivation and Context
Twitch/Amazon IVS uses server side configuration for eRTMP Enhanced Broadcasting/multitrack video stream configuration, so users don't have to manually configure renditions being sent
ertmp_configuration_url
(andertmp_configuration_name
) are exposed in the service json configuration to allow other services to adopt the same configuration mechanism without additional code changesHow Has This Been Tested?
This is in use in the Twitch Enhanced Broadcasting Beta
Types of changes
Checklist: