-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add (eRTMP) multitrack video output #10633
UI: Add (eRTMP) multitrack video output #10633
Conversation
9a86687
to
f910c0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is clearly not implemented in a future-proof way, it tangles even more service behavior in the UI that should be plugin-ified (with APIs).
Continuously shoehorning service integrations was already a mistake, and this PR goes to the same wrong direction rather than trying to go to a better direction.
7b7c4e7
to
76bde8f
Compare
a853a6b
to
b4f7a5e
Compare
be16cb1
to
25ffb6c
Compare
439afe6
to
48cb2a9
Compare
Rebased first. Now pushing cleanups:
|
48cb2a9
to
932269d
Compare
932269d
to
963dab6
Compare
@RytoEX, @Warchamp7: moved the remaining service settings into groupboxes after #10633 (comment) |
c76ef2b
to
696e9d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started a review a while back and forgot to submit it. Submitting it now so get this one feedback item raised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to autosquash locally, but it looks like some of the autosquash commits are trying to apply changes to commits before the actual base changes the autosquash commits try to fixup. Could you squash the commits?
Per @Warchamp7 , the UI itself is okay. @Lain-B and I are still doing code review.
95df074
to
7ec786f
Compare
@RytoEX: commits are squashed, apologies for the unclean fixup commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for rebasing. There are a few minor things, such as Linux/macOS just not being implemented at all and failing with "GPU not supported", but generally it has my approval. We'll probably just have to ifdef out the Linux/macOS codepath for it and disable it for the time being but otherwise again it generally has my approval.
Dumping config json from nlohmann requires more than 4096 bytes
7ec786f
to
9031cdd
Compare
Rebased to latest master. May push trivial fixes (text nits + minor cleanups or just text nits) before merging. |
If possible, we'd like to keep the implementation as-is so we can release server-side updates to start vending ladders for Linux, MacOS, AMD AMF, and Intel QSV without requiring additional changes to OBS. In the short term, we can improve the error message that is shown so that it makes it more apparent to users that the reason it is unsupported is not the build of OBS Studio, but instead the service that vends the configuration. |
Disables all children of the properties view.
9031cdd
to
1aa8111
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a brief review comment for posterity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failures are unrelated. The GitHub Actions Ubuntu runners are restarting due to some issue related to apt packages that indicate they require service restarts.
Note that this PR includes a bunch of merges from currently open PRs and a FIXME commit to help with testing, which will go away as soon as the dependency PRs are mergedDescription
This implements multitrack video support for Twitch Enhanced Broadcasting and Amazon IVS Multitrack Video
Motivation and Context
Multitrack video/Enhanced Broadcasting allows sending multiple video tracks/renditions from the users machine, resulting in generally higher quality renditions at lower bitrates compared to single track streaming with server side transcoding, since e.g. losses roundtripping frames through another decode/encode step are removed.
Enhanced Broadcasting/multitrack video uses server side configuration to provide easier onboarding for users, and balanced values for the number of renditions and their bitrates.
How Has This Been Tested?
This has been tested in the Twitch Enhanced Broadcasting beta
Types of changes
Checklist: