libobs: Fix obs_parse_avc_header missing high profile parameters #10657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds extended information for high* profiles to
obs_parse_avc_header().Motivation and Context
When testing #10608 I received a warning from a third party tool that the
AVCDecoderConfigurationRecordproduced byobs_parse_avc_header()was missing these things.ISO/IEC 14496-15 Section 5.3.3.1.2 says this should be present for high/high10/high422/high444 profiles (high and high444 are supported by OBS).
Given that nobody cared for the past 10 years this is not critical, but still nice to be correct.
How Has This Been Tested?
Recorded a video with #10608 and validated the data is now present.
Types of changes
Checklist: