Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Enforce completely Fusion Qt style on Linux #10719

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented May 24, 2024

Description

As of 8dcfae9, indicating the base style to the proxy is completely functional.

It also bypasses QT_STYLE_OVERRIDE and -style, but since the system theme is no longer available on Linux this is a non-issue.

Motivation and Context

Rewrite of #6664 to use the conventional method to enforce a Qt style.

Since #10602, issues with the conventional method were fixed since there is one style for the whole app.

Also #9653 phased out the system theme on Linux and other themes only support Fusion as a base style on Linux.

So the side-effect of #6664 allowing the user to set their own Qt style is mostly unusable and potentially unwanted.

How Has This Been Tested?

Enforced system theme in the config file, and try to ran OBS with Breeze enforced.
With the PR, Fusion was in use and not Breeze.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

As of 8dcfae9, indicating the base
style to the proxy is completely functional.

It also bypasses QT_STYLE_OVERRIDE and -style, but since the system
theme is no longer available on Linux this is a non-issue.
@WizardCM WizardCM added the Code Cleanup Non-breaking change which makes code smaller or more readable label May 24, 2024
@Lain-B Lain-B merged commit 34d577d into obsproject:master May 25, 2024
15 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 25, 2024
@tytan652 tytan652 deleted the linux_have_no_system_theme_so_we_can_completely_enforce_fusion branch May 26, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants