CI: Remove PVS Analysis GitHub Action #11529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Action regularly ends up in a broken state as the PVS license needs to be manually renewed continuously, but there has been no effort to ensure this happens regularly. In the same vein, the analysis data itself has not resulted in any real action being taken to fix or analyze them (some issues have been marked as false positives, so shout out to R1ch who take care of that). Thus the generated data has become noise and the code a maintenance burden without value, so it's better to remove it.
WizardCM
added
Code Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove PVS Analysis Action from GitHub workflows to fix scheduled workflow run status.
Motivation and Context
The GitHub Action regularly ends up in a broken state as the PVS license needs to be manually renewed continuously, but there has been no effort to ensure this happens regularly.
As of today (2024-11-16) the action has failed every night for about a month, without anyone taking action on this, which very obviously means that there is no "user" of this action or the data it generates (some issues have been marked as false positives, so shout out to @notr1ch who took care of that).
Thus the generated data has become noise and the code a maintenance burden without value, so it's better to remove it.
How Has This Been Tested?
Can only be tested by observing scheduled nightly workflow runs after merging.
Types of changes
Checklist: