Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Adjust styling for Sources list #11555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Warchamp7
Copy link
Member

@Warchamp7 Warchamp7 commented Nov 22, 2024

Description

Minor adjustment to the SourceTreeItem sizeHint calculation and styling rule cleanup.

This also fixes the items in the Sources list being different sizes than the Scene list, which is a bug.

Motivation and Context

There are a few confusing SourceTree specific style rules to account for the fact it uses a QListView with custom widgets instead of a QListWidget. This PR tidies that up a little bit and also removes some unnecessary rules targeting the SceneTree widget.

How Has This Been Tested?

Compiled and checked visual changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality labels Nov 22, 2024
@Warchamp7 Warchamp7 added the UI/UX Anything to do with changes or additions to UI/UX elements. label Nov 23, 2024
@Warchamp7 Warchamp7 force-pushed the sourcetree-styling-tweaks branch from ab364a1 to fc1c4c6 Compare January 28, 2025 21:02
@Warchamp7 Warchamp7 added this to the OBS Studio 31.1 milestone Feb 6, 2025
@Warchamp7 Warchamp7 force-pushed the sourcetree-styling-tweaks branch from fc1c4c6 to b6c7795 Compare February 7, 2025 00:17
@Warchamp7 Warchamp7 changed the title UI: Adjust styling for Sources list frontend: Adjust styling for Sources list Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

3 participants