libobs: Do not lock sources mutex unnecessarily #11820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In obs_load_sources(), the master sources mutex was being locked seemingly unnecessarily. This could cause race conditions if used incorrectly.
Lain-B
added
Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sources mutex does not need to be manually locked when calling
obs_load_sources().Motivation and Context
Noticed that #11687 was opened due to the fact that the sources mutex was being locked here. #11687 will probably be unnecessary after merging this PR.
How Has This Been Tested?
Only lightly tested. Things seem okay but could use some extra testing.
Types of changes
Checklist: