Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvases - Part One (libobs) #11823
base: master
Are you sure you want to change the base?
Canvases - Part One (libobs) #11823
Changes from all commits
78edf37
c32757f
b8a8f72
3f25c89
0c72738
7ae8309
8b1352e
0cd0b70
4979769
415ac57
ef8da66
63f97a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first one is actually not proper English 🇬🇧 but it is what it is. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In cases like this I usually prefer to have the
0
andOR
also represented in monospace (just like with this comment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAIN
is never available to actual API users, it's kind of a magic internal value that is removed whenever an API user tries to pass it as part if their flags anyway.Should it be documented at all then (depends on the intended audience for this documentation I'd guess)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally my intention was to have this so you can ignore the main canvas when enumerating canvases to find only auxiliary ones. Of course you could also compared pointers (obtained via
obs_get_main_canvas()
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity: What kind of canvas would not hold scene source references (like, which functionality/usecases would be based on a "scene-less" canvas)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an explicit line-break here?