fix: non school teachers cannot be admins

cfl_common/common/migrations/0056_set_non_school_teachers_as_non_admins.py

@@ -0,0 +1,26 @@
+from django.apps.registry import Apps
+from django.db import migrations
+
+
+def set_non_school_teachers_as_non_admins(apps: Apps, *args):
+    Teacher = apps.get_model("common", "Teacher")
+
+    Teacher.objects.filter(
+        new_user__is_active=True,
+        is_admin=True,
+        school__isnull=True,
+    ).update(is_admin=False)
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("common", "0055_alter_schoolteacherinvitation_token"),
+    ]
+
+    operations = [
+        migrations.RunPython(
+            code=set_non_school_teachers_as_non_admins,
+            reverse_code=migrations.RunPython.noop,
+        ),
+    ]

cfl_common/common/migrations/0057_teacher_teacher__is_admin.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.2.17 on 2025-01-13 17:34
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("common", "0056_set_non_school_teachers_as_non_admins"),
+    ]
+
+    operations = [
+        migrations.AddConstraint(
+            model_name="teacher",
+            constraint=models.CheckConstraint(
+                check=models.Q(("is_admin", True), ("school__isnull", True), _negated=True), name="teacher__is_admin"
+            ),
+        ),
+    ]

cfl_common/common/models.py

@@ -126,6 +126,17 @@ class Teacher(models.Model):
 
     objects = TeacherModelManager()
 
+    class Meta:
+        constraints = [
+            models.CheckConstraint(
+                check=~models.Q(
+                    school__isnull=True,
+                    is_admin=True,
+                ),
+                name="teacher__is_admin",
+            )
+        ]
+
     def teaches(self, userprofile):
         if hasattr(userprofile, "student"):
             student = userprofile.student