feat: outlook button on verify email #2262
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
portal/templates/portal/email_verification_needed.html line 15 at r1 (raw file):
<a target="_blank" href="https://mail.google.com/mail/#search/from%3Ano-reply%40codeforlife.education+subject%3AEmail+Verification" class="button button--home button-email">Open in Gmail</a> <a target="_blank" href="https://outlook.live.com/mail/"
I know it's a horrible link but can we use this instead: https://login.live.com/login.srf?wa=wsignin1.0&rpsnv=21&ct=1707908956&rver=7.0.6738.0&wp=MBI_SSL&wreply=https%3a%2f%2foutlook.live.com%2fowa%2f%3fcobrandid%3dab0455a0-8d03-46b9-b18b-df2f57b9e44c%26nlp%3d1%26deeplink%3dowa%252f%253fstate%253d1%26redirectTo%3daHR0cHM6Ly9vdXRsb29rLmxpdmUuY29tL21haWwv%26RpsCsrfState%3d783acd27-aed6-6e3d-bc1e-eb90b12fbe33&id=292841&aadredir=1&CBCXT=out&lw=1&fl=dob%2cflname%2cwld&cobrandid=ab0455a0-8d03-46b9-b18b-df2f57b9e44c
This is because the one you used only gets the user to the Outlook landing page, not the sign in page. Outlook changed this recently and it's horrible (Outlook is horrible)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
portal/templates/portal/email_verification_needed.html line 15 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
I know it's a horrible link but can we use this instead: https://login.live.com/login.srf?wa=wsignin1.0&rpsnv=21&ct=1707908956&rver=7.0.6738.0&wp=MBI_SSL&wreply=https%3a%2f%2foutlook.live.com%2fowa%2f%3fcobrandid%3dab0455a0-8d03-46b9-b18b-df2f57b9e44c%26nlp%3d1%26deeplink%3dowa%252f%253fstate%253d1%26redirectTo%3daHR0cHM6Ly9vdXRsb29rLmxpdmUuY29tL21haWwv%26RpsCsrfState%3d783acd27-aed6-6e3d-bc1e-eb90b12fbe33&id=292841&aadredir=1&CBCXT=out&lw=1&fl=dob%2cflname%2cwld&cobrandid=ab0455a0-8d03-46b9-b18b-df2f57b9e44c
This is because the one you used only gets the user to the Outlook landing page, not the sign in page. Outlook changed this recently and it's horrible (Outlook is horrible)
Done.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
This change is