Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move admin given/revoked emails to dotdigital #2292

Merged
merged 8 commits into from
May 2, 2024

Conversation

evemartin
Copy link
Contributor

@evemartin evemartin commented May 1, 2024

This change is Reviewable

@evemartin evemartin changed the title move admin given/revoked emails to dotdigital fix: move admin given/revoked emails to dotdigital May 1, 2024
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @evemartin)


cfl_common/common/mail.py line 114 at r1 (raw file):

    # pylint: enable=line-too-long

    if MODULE_NAME == "local":

Can you just add a comment here explaining why we're doing this check here, just in case we forget in the future x)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

@faucomte97 faucomte97 merged commit c9fddfb into master May 2, 2024
5 checks passed
@faucomte97 faucomte97 deleted the move-admin-given-and-revoked-emails branch May 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants