Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add links to Python Den #2342

Merged
merged 4 commits into from
Aug 29, 2024
Merged

feat: Add links to Python Den #2342

merged 4 commits into from
Aug 29, 2024

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Aug 28, 2024

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Aug 28, 2024
@faucomte97 faucomte97 linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link
Contributor

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @faucomte97)


portal/templates/portal/play.html line 112 at r1 (raw file):

                <h5 class="mt-0">Python programming</h5>
                <p>The Python Den is an exploration of Python programming
                    through a comprehensive course. Free lesson plans, videos

Maybe combine these two sentences with a "with" between "comprehensive course" and "Free lesson plans"?


portal/templates/portal/teach.html line 158 at r1 (raw file):

                <div class="flex-grow-1">
                    <h4 class="mt-0">Python programming</h4>
                    <p>The Python Den (Beta) is an exploration of Python

The "(Beta)" isn't used in the other blocks of Python Den text - for consistency's sake, maybe either add it elsewhere or remove it here


portal/templates/portal/teach.html line 159 at r1 (raw file):

                    <h4 class="mt-0">Python programming</h4>
                    <p>The Python Den (Beta) is an exploration of Python
                        programming through a comprehensive course. Free

Same as one of my previous comments, maybe combine these first two sentences with a "with"?


portal/templates/portal/play/student_dashboard.html line 66 at r1 (raw file):

                <section><img title="Rapid Router logo" alt="Rapid Router logo" src="{% static 'portal/img/RR_logo_simple.png' %}"></section>
                <h4>You have completed {{ rapid_router.num_completed }} Rapid
                    Router level{{ num_completed|pluralize }}!</h4>

Does this also need to be rapid_router.num_completed?


portal/tests/test_views.py line 573 at r1 (raw file):

                "num_top_scores": 0,
                "total_score": 0,
                "total_available_score": 830,

Out of curiosity, how did you get this number?


portal/views/student/play.py line 61 at r1 (raw file):

            context_data["rapid_router"]["total_custom_score"] = (
                custom_levels_data

Also out of curiosity, why is custom_levels_data here within parentheses but below it's not?

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @evemartin)


portal/templates/portal/play.html line 112 at r1 (raw file):

Previously, evemartin wrote…

Maybe combine these two sentences with a "with" between "comprehensive course" and "Free lesson plans"?

Done.


portal/templates/portal/teach.html line 158 at r1 (raw file):

Previously, evemartin wrote…

The "(Beta)" isn't used in the other blocks of Python Den text - for consistency's sake, maybe either add it elsewhere or remove it here

Done.


portal/templates/portal/teach.html line 159 at r1 (raw file):

Previously, evemartin wrote…

Same as one of my previous comments, maybe combine these first two sentences with a "with"?

Done.


portal/templates/portal/play/student_dashboard.html line 66 at r1 (raw file):

Previously, evemartin wrote…

Does this also need to be rapid_router.num_completed?

Yes 🙃


portal/tests/test_views.py line 573 at r1 (raw file):

Previously, evemartin wrote…

Out of curiosity, how did you get this number?

It's what the code that compute the scores got, so it seems that by adding all the max scores for the Python Den levels, you can get a total score of 830.


portal/views/student/play.py line 61 at r1 (raw file):

Previously, evemartin wrote…

Also out of curiosity, why is custom_levels_data here within parentheses but below it's not?

I think that's just Black doing its thing. If the assignment spills onto the next line it needs to be in brackets otherwise the code doesn't compile, whereas below the assignment still happens on the same line technically.

Copy link
Contributor

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)


portal/tests/test_views.py line 573 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

It's what the code that compute the scores got, so it seems that by adding all the max scores for the Python Den levels, you can get a total score of 830.

Oh neat!


portal/views/student/play.py line 61 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

I think that's just Black doing its thing. If the assignment spills onto the next line it needs to be in brackets otherwise the code doesn't compile, whereas below the assignment still happens on the same line technically.

Ah I see, very helpful of Black :))

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @evemartin from 2 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions

@faucomte97 faucomte97 merged commit 3ac054d into master Aug 29, 2024
7 checks passed
@faucomte97 faucomte97 deleted the python_den_links branch August 29, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create links to Python Den
2 participants