Removes user levels from episodes (#1006)

* New migration removes user levels from episodes * Uses filters instead of ifs and try excepts
ocadotechnology · Feb 1, 2019 · e0dcac6 · e0dcac6
1 parent 400869d
commit e0dcac6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/...rations/0069_fix_episodes_order_part_2.py → .../0069_remove_user_levels_from_episodes.py b/...rations/0069_fix_episodes_order_part_2.py → .../0069_remove_user_levels_from_episodes.py
@@ -38,22 +38,17 @@
 
 
 def update_episodes_level_order(apps, schema_editor):
+    Episode = apps.get_model('game', 'Episode')
     Level = apps.get_model('game', 'Level')
-    episode7_levels = []
-    episode8_levels = []
-
-    for episode7_level_name in range(51, 61):
-        episode7_levels.append(Level.objects.get(name=episode7_level_name))
-
-    for episode8_level_name in range(61, 68):
-        episode8_levels.append(Level.objects.get(name=episode8_level_name))
 
-    Episode = apps.get_model('game', 'Episode')
     episode7 = Episode.objects.get(id=7)
     episode8 = Episode.objects.get(id=8)
 
-    episode7.level_set = episode7_levels
-    episode8.level_set = episode8_levels
+    episode7_new_levels = Level.objects.filter(episode=episode7, owner=None)
+    episode8_new_levels = Level.objects.filter(episode=episode8, owner=None)
+
+    episode7.level_set = episode7_new_levels
+    episode8.level_set = episode8_new_levels
 
     episode7.save()
     episode8.save()

diff --git a/game/tests/migrations/test_migration_fix_episodes_order.py b/game/tests/migrations/test_migration_fix_episodes_order.py
@@ -40,7 +40,7 @@
 class TestMigrationReorderEpisodes(MigrationTestCase):
 
     start_migration = '0067_level_score_27'
-    dest_migration = '0069_fix_episodes_order_part_2'
+    dest_migration = '0069_remove_user_levels_from_episodes'
 
     def test_episodes_renamed_properly(self):
         Episode = self.django_application.get_model('game', 'Episode')