Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Buttons in level editor popup #1539

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix: Buttons in level editor popup #1539

merged 3 commits into from
Nov 28, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 27, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #1539 (b29b6aa) into master (31dde05) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head b29b6aa differs from pull request most recent head c9d2749. Consider uploading reports for the commit c9d2749 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
- Coverage   91.79%   91.67%   -0.12%     
==========================================
  Files         110      110              
  Lines        5860     5860              
==========================================
- Hits         5379     5372       -7     
- Misses        481      488       +7     

see 3 files with indirect coverage changes

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 4ceb8a7 into master Nov 28, 2023
3 checks passed
@faucomte97 faucomte97 deleted the editor_buttons branch November 28, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants