Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add snow and city solar panel graphics #1716

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

evemartin
Copy link
Contributor

@evemartin evemartin commented Sep 3, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @evemartin)


game/static/game/image/decor/city/solar_panel.svg line 1 at r1 (raw file):

<?xml version="1.0" encoding="UTF-8"?>

As far as I can tell, this image (and the other one) are also needed in the static/game/raphael-image/decor/ directory - right now they don't appear in the level editor properly.

Copy link
Contributor Author

@evemartin evemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


game/static/game/image/decor/city/solar_panel.svg line 1 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

As far as I can tell, this image (and the other one) are also needed in the static/game/raphael-image/decor/ directory - right now they don't appear in the level editor properly.

I've now uploaded the images to all the places where the original solar panel image appears and confirmed locally that they show up properly!

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, 4 of 4 files at r2, 174 of 174 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

@faucomte97 faucomte97 linked an issue Sep 4, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @evemartin)

@evemartin evemartin merged commit 53beace into master Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement solar panels for Snow and City themes
2 participants