-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add snow and city solar panel graphics #1716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @evemartin)
game/static/game/image/decor/city/solar_panel.svg
line 1 at r1 (raw file):
<?xml version="1.0" encoding="UTF-8"?>
As far as I can tell, this image (and the other one) are also needed in the static/game/raphael-image/decor/
directory - right now they don't appear in the level editor properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game/static/game/image/decor/city/solar_panel.svg
line 1 at r1 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
As far as I can tell, this image (and the other one) are also needed in the
static/game/raphael-image/decor/
directory - right now they don't appear in the level editor properly.
I've now uploaded the images to all the places where the original solar panel image appears and confirmed locally that they show up properly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, 4 of 4 files at r2, 174 of 174 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @evemartin)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @evemartin)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)