Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worksheet counter and accordion arrows #1759

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jan 7, 2025

This change is Reviewable

@SKairinos SKairinos linked an issue Jan 7, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)


game/templates/game/python_den_level_selection.html line 237 at r1 (raw file):

                                        {% endif %}
                                        <div class="col-sm-10 python-den-level">
                                            <a class="disabled">{{episode.name}}{% if episode.counter > 0 %} pt. {{ forloop.counter }}{% endif %}</a>

image.png

Seems like neither worksheet has the "pt." text next to it 😞


game/templates/game/python_den_level_selection.html line 245 at r1 (raw file):

                                    {% else %}
                                        <div class="col-sm-7 python-den-level">
                                            <a href="https://editor.raspberrypi.org/en/projects/blank-python-starter" target="_blank">{{episode.name}}{% if episode.counter > 0 %} pt. {{ forloop.counter }}{% endif %}</a>

image.png

Not sure why but the worksheet for the For Loops episode has disappeared, so has level 41.

@SKairinos
Copy link
Contributor Author

SKairinos commented Jan 10, 2025

fixed.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


game/templates/game/python_den_level_selection.html line 237 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

image.png

Seems like neither worksheet has the "pt." text next to it 😞

Can the first worksheet have "pt. 1" next to it? 🙏

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 0494803 into master Jan 14, 2025
5 checks passed
@SKairinos SKairinos deleted the rapid-router-1758 branch January 14, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Den levels page - fixes
2 participants