-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests and bug fixes #5
base: master
Are you sure you want to change the base?
Conversation
This counteracts the locality of mktime.
Also, print Z when timezone offset is 0 and introduce *_utc function variations for those printers that lack timezone specifiers.
The fixed UNIX time tests hedge against bugs in the test apparatus.
Sounds very nice! I did not review all the PR deeply, but I need to stop for now. Just a note about commits 08d88ee, 04ec7d6 and 8c87fa0: And I'll double check changes this evening, but for what I saw it looks like very good to me, really. |
Using What do you think about an optional argument for shortening timezone printing? Also, a character would be needed for custom printing format allowing this, but I see no obvious character to do so... |
Do not lose hope, I will find time to review and adapt this PR... |
This patchset introduces a test suite using alcotest which covers parsing, printing, and roundtripping (composed parsing/printing and printing/parsing).
Bug fixes include:
Features include:
+00:00
as allowed by the standard.*_utc
variants have been added to print the UTC timezone-less dates and times.