-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port build to dune #40
base: master
Are you sure you want to change the base?
Port build to dune #40
Conversation
Before it would default to the machine's time zone and fail if the machine was not on UTC.
I had to create |
@Leonidas-from-XIV Before I did in, did you also fix the weird not-releasing-from-trunk issue for this repo? We should really make it follow normal expectations. |
No, I haven't looked at releasing yet, but I don't quite see what would prevent releasing from trunk? I tried this branch and it looks like when you install it you are getting the same API as the 2.04 release. It is a bit tricky to test but at least my surface-level testing worked, and so did the tests. I also noticed that there is a |
I recommend we simply pull the stuff from the branch onto the trunk and make this work the way every other thing works. |
Just had a quick look at the changes in the |
Please do it then. |
As I don't have commit rights, I can only create a PR: #41 |
I've merged the PR to pull the 3.x branch to the main branch. If you could clean this up I'll merge after. Also, I can give you commit access if you would like. |
This will make the build of the library a bit more future proof and easier for people to understand and contribute given
dune
is well-accepted.