Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade workflow versions #88

Merged
merged 1 commit into from
Jul 23, 2024
Merged

ci: Upgrade workflow versions #88

merged 1 commit into from
Jul 23, 2024

Conversation

liyishuai
Copy link
Member

@liyishuai liyishuai commented Jul 15, 2024

@liyishuai liyishuai self-assigned this Jul 15, 2024
@liyishuai liyishuai force-pushed the ci-upgrade branch 2 times, most recently from 618b587 to 57bb687 Compare July 15, 2024 08:17
@pmetzger
Copy link
Member

Seems sane to me. Do you know why the CI is spitting up on this change?

@liyishuai
Copy link
Member Author

GitHub has upgraded the latest version of Mac to use ARM chips, which the old version of setup-ocaml doesn't like. The new version of setup-ocaml drops support for old versions of OCaml on some OS's. I'll try to figure out how to support the most OS*OCaml versions possible.

@liyishuai liyishuai mentioned this pull request Jul 16, 2024
@pmetzger
Copy link
Member

It would certainly be nice to have at least some x86 + Mac coverage.

@pmetzger
Copy link
Member

BTW, if you want to look more broadly at the ocaml-community CI workflows, that would be very welcome.

@liyishuai liyishuai force-pushed the ci-upgrade branch 4 times, most recently from f85d548 to 60b279d Compare July 17, 2024 09:38
@liyishuai liyishuai marked this pull request as draft July 17, 2024 10:06
@pmetzger
Copy link
Member

@liyishuai let us know when you feel ready to commit this.

@liyishuai liyishuai force-pushed the ci-upgrade branch 2 times, most recently from 2b06b6e to d29f726 Compare July 19, 2024 07:24
@liyishuai liyishuai marked this pull request as ready for review July 19, 2024 09:39
@liyishuai
Copy link
Member Author

Almost there.

The current failure says uninstallation unsuccessful. Not sure why OPAM tries to install packages in an uninstall command.

@pmetzger
Copy link
Member

@liyishuai BTW, you should now have direct commit access.

@pmetzger
Copy link
Member

@liyishuai Feel free to commit when you feel it's appropriate.

@liyishuai liyishuai merged commit 5636cac into master Jul 23, 2024
73 checks passed
@liyishuai liyishuai deleted the ci-upgrade branch July 23, 2024 16:57
@pmetzger
Copy link
Member

@liyishuai If you had time to fix up the CI for the other stuff in ocaml-community it would be a real help!

@liyishuai
Copy link
Member Author

I saw many other projects use https://github.com/ocurrent/ocaml-ci instad of GitHub Actions.

  • For Cppo: I propose keeping the CI as-is, unless OCaml-CI has a better support for testing the dependants.
  • For community projects with no CI yet: I'll open an issue that suggests choosing a platform, and offer help for GH Actions.
  • For existing projects with GH Actions: I can start working on them, while keeping track of Documentation for compatibility ocaml/setup-ocaml#828. Expect low bandwidth as I'm caught in works recently.

@pmetzger
Copy link
Member

Your plan seems fine! Thank you so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants