Add utf8 support for string literal #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
force-pushed
the
utf8
branch
3 times, most recently
from
3740720
to
dc6f14c
Compare
hhugo
changed the title
|
So the documentation doesn't (yet!) officially say if we can assume source files are UTF-8, but I presume that's imminent. |
|
This is a much missed feature, thanks for working on it and fingers crossed we can make it work soon. My guess is: if you're not using this feature, we would not be requiring any assumption regarding the file's encoding? So this would be opt-in only correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for utf-8 encoded string. It fixes #90.
This only work if we assume the source is encoded in utf8.
Note that OCaml 5.3 has the following entry in its changelog.