Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated menhir && menhirLib to 20231231 #294

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated menhir && menhirLib to 20231231 #294

wants to merge 4 commits into from

Conversation

Chimrod
Copy link
Contributor

@Chimrod Chimrod commented Jan 14, 2024

No description provided.

@toots
Copy link
Member

toots commented Jan 14, 2024

Thanks for this. The CI error seems unrelated I will investigate it asap.

toots
toots reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@toots toots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed the CI! Here are some comments for until it completes:

packages/menhirLib-windows/menhirLib-windows.20231231/opam Outdated Show resolved Hide resolved
packages/menhir-windows/menhir-windows.20231231/opam
Comment on lines +18 to +20
"menhirLib" {= version}
"menhirSdk" {= version}
"menhirCST" {= version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to depend on the -windows packages here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toots toots toots left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chimrod @toots