[new release] uri, uri-sexp, uri-re and uri-bench (4.3.0) #23690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Apr 19, 2023
There was a problem hiding this comment.
There is also a missing (package uri-re) in this part of the tests
#=== ERROR while compiling uri.4.3.0 ==========================================#
# context 2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.09.1 | pinned(https://github.com/mirage/ocaml-uri/releases/download/v4.3.0/uri-4.3.0.tbz)
# path ~/.opam/4.09/.opam-switch/build/uri.4.3.0
# command ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p uri -j 255
# exit-code 1
# env-file ~/.opam/log/uri-7-69c770.env
# output-file ~/.opam/log/uri-7-69c770.out
### output ###
# File "fuzz/dune", line 4, characters 16-22:
# 4 | (libraries uri uri-re crowbar)
# ^^^^^^
# Error: Library "uri-re" not found.
# -> required by _build/default/fuzz/fuzz.exe
# -> required by alias fuzz/runtest in fuzz/dune:2
# (cd _build/default/lib_test && ./test_runner.exe)
# ....................................................................................................................................................................................................................................................................................
# Ran: 276 tests in: 0.15 seconds.
# OK
CHANGES: * Add `Uri.Absolute_http`, an RFC9110-compliance specialization of a `Uri.t`. (mirage/ocaml-uri#164 mirage/ocaml-uri#162 @torinnd). * Add a `uri-bench` package for the benchmarking dependencies in this repository (mirage/ocaml-uri#166 @tmcgilchrist).
kit-ty-kate
force-pushed
the
release-uri-v4.3.0
branch
from
cb22f94
to
fac4cf9
Compare
|
Need to regenerate this source package with @kit-ty-kate 's fix in it. |
|
ping |
|
Any updates on this? |
|
This PR is not ready, at the same time, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An RFC3986 URI/URL parsing library
CHANGES:
Uri.Absolute_http, an RFC9110-compliance specialization of aUri.t. (Introduce Absolute_http specialization mirage/ocaml-uri#164 More strongly-typed HTTP and HTTPS URIs mirage/ocaml-uri#162 @torinnd).uri-benchpackage for the benchmarking dependencies in thisrepository (Setup uri-bench to build benchmarking code. mirage/ocaml-uri#166 @tmcgilchrist).