Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] reason-react (2 packages) (0.15.0) #26376

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

jchavarri
Copy link
Contributor

Reason bindings for React.js

CHANGES:

CHANGES:

* Add `isValidElement` (@r17x in
  reasonml/reason-react#837)
* Add `startTransition` (@r17x in
  reasonml/reason-react#838)
* Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has
  the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in
  [reasonml/reason-react#839](reasonml/reason-react#839))
* Add CSS Box Alignment Module Level 3 (@davesnx in
  reasonml/reason-react#847)
* Fix: Remove "unique `key` prop" warnings from multi-child fragment elements
  (@jchavarri in reasonml/reason-react#852)
@jchavarri
Copy link
Contributor Author

#=== ERROR while fetching sources for melange-recharts.4.0.3 ==================#
OpamSolution.Fetch_fail("/usr/bin/opam: \"symlink\" failed on /home/opam/.opam/download-cache/sha256/12/1295e56c252d53ca85bf814404e4bc40b02ba095b33cd48cd1b44d05514bae0c: Permission denied")

Sorry, I don't understand what these errors mean and why they're happening. Seems like some file permission issues in the ci node?

@dinosaure
Copy link
Contributor

To clarify, this package seems fine to merge but a specific revdep (melange-fest) fails because curl can not download a package. However, we can not say that it's really good to merge because we don't know if your package has a (subtle) breaking change which will break melange-fest). So, a double-look is needed.

@hannesm
Copy link
Member

hannesm commented Aug 22, 2024

@jchavarri the issue you mentioned was reported (and allegedly fixed) ocurrent/ocaml-ci#962

I restarted the failed builds, let's see whether this time curl has more luck (earlier it was exiting with code 6, which is "could not resolve host" -- for a github.com download that sounds like a temporary issue.

@jchavarri
Copy link
Contributor Author

Thanks for the help. In the last build, some things were fixed but there is still this networking error:

[ERROR] Failed to get sources of jsonrpc.1.19.0, lsp.1.19.0 (https://github.com/ocaml/ocaml-lsp/releases/download/1.19.0/lsp-1.19.0.tbz): Curl failed

Any clues? Thanks again for your time.

@dinosaure
Copy link
Contributor

lambda-soup was merged (see #26388) was merged and has the same kind of error. Some ready-to-merge PRs has the same issue. We can consider this PR as ready to merge. Thanks for your patience.

@dinosaure dinosaure merged commit 24c425b into ocaml:master Aug 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants