Bugfix:Fixed obproxyd.sh script terminator error and description error #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberLife-Markus
commented
Sep 26, 2022
CyberLife-Markus
commented
- Fixed an issue with terminator errors causing scripts to not run
- Fixed a problem with incorrect caption description
lemon0910
reviewed
Nov 21, 2022
| @@ -145,7 +145,7 @@ void ObProxyMain::print_usage() const | |||
| MPRINT(" -R,--releaseid RELEASEID current obproxy kernel release id"); | |||
| MPRINT(" -t,--regression_test TEST_NAME regression test"); | |||
| MPRINT("example:"); | |||
| MPRINT(" run without config server:"); | |||
| MPRINT(" run without root service list:"); | |||
There was a problem hiding this comment.
config server指的是OCP提供的服务，用OCP service应该更好理解
There was a problem hiding this comment.
这里是描述写错了，下边151行还有一处run with config server
There was a problem hiding this comment.
https://github.com/oceanbase/oceanbase/tree/master/tools/ob-configserver 从这个仓库来看是可自建config server的，下方调整为OCP service感觉有些局限
lemon0910
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.