Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): cannot rollback update changelog status #4198

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

guowl3
Copy link
Collaborator

@guowl3 guowl3 commented Jan 23, 2025

What type of PR is this?

type-bug

What this PR does / why we need it:

Transaction will rollback if update status in executeScheduleChange method, so we need to update status in call method

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@guowl3 guowl3 added the type-bug Something isn't working label Jan 23, 2025
@guowl3 guowl3 added this to the ODC4.3.3-bp1 milestone Jan 23, 2025
@guowl3 guowl3 self-assigned this Jan 23, 2025
@guowl3 guowl3 requested a review from LioRoger as a code owner January 23, 2025 09:57
@guowl3 guowl3 changed the title fix(changelog): revert commit and catch exception in alterScheduleTask fix(changelog): cannot rollback update changelog status Jan 23, 2025
@guowl3 guowl3 requested a review from MarkPotato777 January 23, 2025 10:32
Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guowl3 guowl3 merged commit ef2f090 into dev/4.3.3 Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

2 participants