Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends Config/Plugin for Deno packaging #504

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AndresPrez
Copy link

@AndresPrez AndresPrez commented Sep 29, 2022

Tackles the oclif/core part for #503.

It paves the way to start supporting deno projects. It essentially extends the logic around using the package.json as the project's root config file to also support Deno's deno.jsonc configuration file.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @AndresPrez to sign the Salesforce.com Contributor License Agreement.

@mdonnalley mdonnalley added waiting for interest Waiting to see if there's strong community interest unlikely Feature we are unlikely to implement labels Mar 5, 2024
debug('config')('loadJSON %s', path)
// Allows reading JSON with comments
const _JSON = path.extname(_path) === '.jsonc' ? JSON5 : JSON
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking out loud here, maybe using dynamic imports here (so json5 isn't loaded by json users) might be kind.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, although it seems salesforce ppl have lost interest in supporting Deno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed unlikely Feature we are unlikely to implement waiting for interest Waiting to see if there's strong community interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants