Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement .skipTo and refactor .stop #12

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

mdonnalley
Copy link
Contributor

  • Add .skipTo
  • Make .goto mark all bypassed steps as completed
  • Refactor .stop to take the final stage to use for the current stage

// The underlying components expect an Error, although they don't currently use anything on the error - they check if it exists.
// Instead of refactoring the components to take a boolean, we pass in a placeholder Error,
// which, gives us the flexibility in the future to pass in an actual Error if we want
const error = finalStatus === 'failed' ? new Error('Error') : undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good call

@iowillhoit iowillhoit merged commit f5e5a8a into main Aug 30, 2024
11 checks passed
@iowillhoit iowillhoit deleted the mdonnalley/skip-to branch August 30, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants