Merge pull request #13 from oclif/mdonnalley/truncate-text-with-new-l…

…ines fix: remove newlines when truncating text
oclif · Oct 4, 2024 · 95a73fa · 95a73fa
2 parents 29103b9 + 5300440
commit 95a73fa
Show file tree

Hide file tree

Showing 3 changed files with 229 additions and 62 deletions.
diff --git a/src/table.tsx b/src/table.tsx
@@ -21,7 +21,15 @@ import {
   RowProps,
   TableOptions,
 } from './types.js'
-import {allKeysInCollection, getColumns, getHeadings, intersperse, maybeStripAnsi, sortData} from './utils.js'
+import {
+  allKeysInCollection,
+  determineWidthOfWrappedText,
+  getColumns,
+  getHeadings,
+  intersperse,
+  maybeStripAnsi,
+  sortData,
+} from './utils.js'
 
 /**
  * Determines the configured width based on the provided width value.
@@ -63,11 +71,6 @@ function determineWidthToUse<T>(columns: Column<T>[], configuredWidth: number):
   return tableWidth < configuredWidth ? configuredWidth : tableWidth
 }
 
-function determineWidthOfWrappedText(text: string): number {
-  const lines = text.split('\n')
-  return lines.reduce((max, line) => Math.max(max, line.length), 0)
-}
-
 function determineTruncatePosition(overflow: Overflow): 'start' | 'middle' | 'end' {
   switch (overflow) {
     case 'truncate-middle': {
@@ -88,7 +91,7 @@ function determineTruncatePosition(overflow: Overflow): 'start' | 'middle' | 'en
   }
 }
 
-function formatTextWithMargins({
+export function formatTextWithMargins({
   horizontalAlignment,
   overflow,
   padding,
@@ -141,34 +144,26 @@ function formatTextWithMargins({
     const {marginLeft, marginRight} = calculateMargins(width - determineWidthOfWrappedText(stripAnsi(wrappedText)))
 
     const lines = wrappedText.split('\n').map((line, idx) => {
-      const {marginLeft: lineSpecificLeftMargin} = calculateMargins(width - stripAnsi(line).length)
+      const {marginLeft: lineSpecificLeftMargin, marginRight: lineSpecificRightMargin} = calculateMargins(
+        width - stripAnsi(line).length,
+      )
 
       if (horizontalAlignment === 'left') {
-        if (idx === 0) {
-          // if it's the first line, only add margin to the right side (The left margin will be applied later)
-          return `${line}${' '.repeat(marginRight)}`
-        }
-
-        // if left alignment, add the overall margin to the left side and right sides
-        return `${' '.repeat(marginLeft)}${line}${' '.repeat(marginRight)}`
+        return idx === 0
+          ? `${line}${' '.repeat(lineSpecificRightMargin - marginRight)}`
+          : `${' '.repeat(marginLeft)}${line}${' '.repeat(lineSpecificRightMargin - marginRight)}`
       }
 
       if (horizontalAlignment === 'center') {
-        if (idx === 0) {
-          // if it's the first line, only add margin to the right side (The left margin will be applied later)
-          return `${line}${' '.repeat(marginRight)}`
-        }
-
-        // if center alignment, add line specific margin to the left side and the overall margin to the right side
-        return `${' '.repeat(lineSpecificLeftMargin)}${line}${' '.repeat(marginRight)}`
+        return idx === 0
+          ? `${' '.repeat(lineSpecificLeftMargin - marginLeft)}${line}${' '.repeat(lineSpecificRightMargin)}`
+          : `${' '.repeat(lineSpecificLeftMargin)}${line}${' '.repeat(lineSpecificRightMargin - marginRight)}`
       }
 
       // right alignment
-      if (idx === 0) {
-        return `${' '.repeat(Math.max(0, lineSpecificLeftMargin - marginLeft))}${line}${' '.repeat(marginRight)}`
-      }
-
-      return `${' '.repeat(lineSpecificLeftMargin)}${line}${' '.repeat(marginRight)}`
+      return idx === 0
+        ? `${' '.repeat(Math.max(0, lineSpecificLeftMargin - marginLeft))}${line}${' '.repeat(lineSpecificRightMargin - marginRight)}`
+        : `${' '.repeat(lineSpecificLeftMargin)}${line}${' '.repeat(lineSpecificRightMargin - marginRight)}`
     })
 
     return {
@@ -178,7 +173,9 @@ function formatTextWithMargins({
     }
   }
 
-  const text = cliTruncate(valueWithNoZeroWidthChars, spaceForText, {position: determineTruncatePosition(overflow)})
+  const text = cliTruncate(valueWithNoZeroWidthChars.replaceAll('\n', ' '), spaceForText, {
+    position: determineTruncatePosition(overflow),
+  })
   const spaces = width - stripAnsi(text).length
   return {
     text,

diff --git a/src/utils.ts b/src/utils.ts
@@ -45,6 +45,11 @@ export function allKeysInCollection<T extends Record<string, unknown>>(data: T[]
   return [...keys]
 }
 
+export function determineWidthOfWrappedText(text: string): number {
+  const lines = text.split('\n')
+  return lines.reduce((max, line) => Math.max(max, line.length), 0)
+}
+
 export function getColumns<T extends Record<string, unknown>>(config: Config<T>, headings: Partial<T>): Column<T>[] {
   const {columns, horizontalAlignment, maxWidth, overflow, verticalAlignment} = config
 
@@ -58,7 +63,7 @@ export function getColumns<T extends Record<string, unknown>>(config: Config<T>,
       const value = data[key]
 
       if (value === undefined || value === null) return 0
-      return stripAnsi(String(value).replaceAll('', ' ')).length
+      return determineWidthOfWrappedText(stripAnsi(String(value).replaceAll('', ' ')))
     })
 
     const header = String(headings[key]).length