Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when using Alt-Tab on Windows or Linux while fullscreen #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsittler
Copy link
Contributor

Don't crash when using Alt-Tab on Windows or Linux while fullscreen. This fix was already present on macOS.

@bsittler
Copy link
Contributor Author

Specifically this crash on Alt-Tab while fullscreened was seen in Windows 10 using the DirectX driver. Pressing the Windows key also crashed it the same way. Both are resolved by this change

@bsittler
Copy link
Contributor Author

The new OpenGL driver on Windows exhibits the same symptoms, unfortunately. Also I got similar crashes in Linux. If I use Alt-Enter to switch to true fullscreen mode, then press the Windows key to access the Start menu (or its Linux equivalent), Meka crashes instantly.

@ocornut
Copy link
Owner

ocornut commented Mar 27, 2023

Where exactly do you get a crash?

Note that enabling this essentially breaks fullscreen mode for me, as I end up with desktop resolution and the MEKA contents in e.g. a quarter of the corner.

@bsittler
Copy link
Contributor Author

bsittler commented Mar 30, 2023

Where exactly do you get a crash?

Note that enabling this essentially breaks fullscreen mode for me, as I end up with desktop resolution and the MEKA contents in e.g. a quarter of the corner.

I see. I use the config file to make MEKA and desktop resolution identical. When I use unmodified current MEKA on Windows and make it fullscreen using Alt-Enter and then tap the Win key, it crashes like this:

image

In the console where I started it I see:

Assertion failed: g_screenbuffer_locked_region != NULL && g_screenbuffer_locked_buffer != NULL, file D:\cygwin64\home\bsitt\src\meka\meka\srcs\video.cpp, line 367

@bsittler bsittler force-pushed the modern_windows_crashless_fullscreen branch from 36bf498 to 5cf1f97 Compare May 11, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants