-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a dropdown box for resources section in the nav-bar #51
Conversation
floydtree
commented
Nov 8, 2023
- Adding a dropdown box to collect all the resources offered in the schema server.
- Removing the old guidelines page, adding references to the Understanding OCSF doc and Contribution guide.
Signed-off-by: rajaspa <[email protected]>
Signed-off-by: rajaspa <[email protected]>
Signed-off-by: rajaspa <[email protected]>
Taking a look. Going to try the |
Signed-off-by: rajaspa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out locally from various views, working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Edit: We need to bump the version, so I changed the approval to a change request. The bit below remains a suggestion to consider. Of the 4 items in the "Resources" dropdown, 3 are links that open a new page, however "Data Types" navigates the schema browser to the its own "Data Types" page. I can see why it was done this, way, however I think "Data Types" should be moved to a sibling of the other top level navigation items. Something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version needs to be bumped from 2.60.0
to 2.61.0
in the top level mix.exs
file.
Signed-off-by: rajaspa <[email protected]>
Ah the version number, pushed a commit for that. About the the dropdown - Yeah I had initially considered the same style, but later arrived at this since Data Type really fits as a resource for the framework. But I am not married to that idea, I would be okay either way. |
Approved. In the interest of time, let's live with this for a bit and decide later if "Data Types" should be moved. |