Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a dropdown box for resources section in the nav-bar #51

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

floydtree
Copy link
Contributor

  1. Adding a dropdown box to collect all the resources offered in the schema server.
  2. Removing the old guidelines page, adding references to the Understanding OCSF doc and Contribution guide.

Screenshot 2023-11-08 at 12 17 47 PM

@mikeradka
Copy link
Contributor

Taking a look. Going to try the gh tool to check out the PR and play around with the new feature a bit.

Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally from various views, working as expected.

Copy link

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rmouritzen-splunk
Copy link
Contributor

rmouritzen-splunk commented Nov 9, 2023

I approved, however I'd like to suggest a change, and if you agree, perhaps implement it with this PR.

Edit: We need to bump the version, so I changed the approval to a change request. The bit below remains a suggestion to consider.

Of the 4 items in the "Resources" dropdown, 3 are links that open a new page, however "Data Types" navigates the schema browser to the its own "Data Types" page. I can see why it was done this, way, however I think "Data Types" should be moved to a sibling of the other top level navigation items. Something like this:

Categories   Classes   Base Event   Dictionary   Objects   Data Types   |   Resources

Copy link
Contributor

@rmouritzen-splunk rmouritzen-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version needs to be bumped from 2.60.0 to 2.61.0 in the top level mix.exs file.

Signed-off-by: rajaspa <[email protected]>
@floydtree
Copy link
Contributor Author

floydtree commented Nov 9, 2023

I approved, however I'd like to suggest a change, and if you agree, perhaps implement it with this PR.

Edit: We need to bump the version, so I changed the approval to a change request. The bit below remains a suggestion to consider.

Of the 4 items in the "Resources" dropdown, 3 are links that open a new page, however "Data Types" navigates the schema browser to the its own "Data Types" page. I can see why it was done this, way, however I think "Data Types" should be moved to a sibling of the other top level navigation items. Something like this:

Categories   Classes   Base Event   Dictionary   Objects   Data Types   |   Resources

Ah the version number, pushed a commit for that. About the the dropdown - Yeah I had initially considered the same style, but later arrived at this since Data Type really fits as a resource for the framework. But I am not married to that idea, I would be okay either way.

@rmouritzen-splunk
Copy link
Contributor

Approved. In the interest of time, let's live with this for a bit and decide later if "Data Types" should be moved.

@mikeradka mikeradka merged commit b38d391 into ocsf:main Nov 9, 2023
1 check passed
@floydtree floydtree deleted the resources branch November 9, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants