Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to retry on HTTP 502/503 #125

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Add option to retry on HTTP 502/503 #125

merged 1 commit into from
Feb 1, 2025

Conversation

pims
Copy link
Contributor

@pims pims commented Jan 31, 2025

Handles retrying the request when Cloudflare's API returns HTTP 502/503.

Closes #124

Handles retrying the request when Cloudflare's API returns HTTP 502/503.

Closes octodns#124
@pims
Copy link
Contributor Author

pims commented Jan 31, 2025

note: this is re-using the retry option for Ratelimit errors (HTTP 429) in order to not add another configuration parameter. If that's acceptable to you, I'll push an update to the documentation. If you'd rather a dedicated retry option, happy to update the code to add this new option.

Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@ross ross merged commit b27c0a6 into octodns:main Feb 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Cloudflare API HTTP 502 or HTTP 503 errors
2 participants