Add trailing dot to record values if it's missing #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a look at the failed check, looks like CI is pulling google-cloud-dns version 0.35.0. I had the same issue. The requirements.txt file specifies version 0.34.2 and when I uninstalled google-cloud-dns from my venv and reinstalled requirements.txt, everything just fine. |
ross
reviewed
Jan 11, 2024
Co-authored-by: Ross McFarland <[email protected]>
Co-authored-by: Ross McFarland <[email protected]>
|
Thanks for reviewing. Committed the two suggested changes. |
|
CI failures is the persistent google module failures and unrelated to the change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this change is to handle an edge case where I am trying to migrate CNAME and MX records from AWS Route53 to GCP Cloud DNS and I encounter an error at the stage where OctoDNS tries to apply the changes. AWS Route53 is stripping away the trailing dots on their platform and GCP doesn't like it.