-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial support for Deno #135
Conversation
chore: add env and vscode Signed-off-by: Kurt King <[email protected]> feat: add initial deno support Signed-off-by: Kurt King <[email protected]> chore: put typescript version Signed-off-by: Kurt King <[email protected]> chore: remove console.log Signed-off-by: Kurt King <[email protected]> chore: update cli.js to use ts file Signed-off-by: Kurt King <[email protected]> chore: remove -S arg from dev cmd Signed-off-by: Kurt King <[email protected]>
Signed-off-by: Kurt King <[email protected]>
We sholudn't replace the Node CLI with Deno. The Deno CLI should be an addition and probably become the recommended way to run Octoherd scripts. But the Node version is used as dependencies in scripts today in order to run the script packages directly using |
Hey @gr2m, I am cross-referencing your response here to consolidate the discussion. I like the idea of having a separate repository and will continue to work on this if you like the direction. What's the next step in getting the repository set up? edit: I'll set up the repository and we can talk about transferring at a later date. |
yeah that's what I'd suggest as well, thank you! |
I can run things locally, so making some progress. I am definitely not as comfortable with Deno as anticipated 😬 😅 I could use some help if anyone is interested. |
thanks for the update! It's always hard in the beginning when figuring things out. Thank you for staying on it |
Try this: const { script } = await import("https://esm.sh/@octoherd/script-hello-world")
// now call `script(octokit, repository, options)` for every repository Replace
|
@gr2m, I have things working now for scripts coming from a URL. I have not figured out how to handle the failures for local files yet. I'm at a stopping point for today, but this feels good. Success
Failures
|
when importing locally, make sure to either use a relative path starting with |
Summary
Migrate from Node to Deno.
Details
This PR migrates the CLI to leverage Deno. I could run things locally to update
master
->main
for a few of my older repositories. The discussion here inspired this PR and works to resolve #5.Testing
.js
and.ts
files.scripts/script.js
andscripts/script.ts
against several of my older repos to update branch protection rules.Remaining Tasks
package.json
scripts (and more?) todeno.json
process.arch
andprocess.platform