Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GH_TOKEN on deploy-storybook job #2155

Merged
merged 3 commits into from
May 5, 2022
Merged

Set GH_TOKEN on deploy-storybook job #2155

merged 3 commits into from
May 5, 2022

Conversation

jerivas
Copy link
Member

@jerivas jerivas commented May 5, 2022

@jerivas jerivas requested a review from jgerigmeyer May 5, 2022 21:23
@jerivas
Copy link
Member Author

jerivas commented May 5, 2022

Hold on, I also need to fix the concurrency issue. Right now only one job is executing for a given branch, instead of one of each kind

@jerivas
Copy link
Member Author

jerivas commented May 5, 2022

I think it worked! https://github.com/oddbird/Metecho/runs/6313978941?check_suite_focus=true

@jerivas
Copy link
Member Author

jerivas commented May 5, 2022

Deploy Storybook docs via GH action on pushes to main branch.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2155 (cdc5dc8) into main (3500c4c) will not change coverage.
The diff coverage is n/a.

❗ Current head cdc5dc8 differs from pull request most recent head 6366726. Consider uploading reports for the commit 6366726 to get more accurate results

@@            Coverage Diff            @@
##              main     #2155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          224       224           
  Lines        11396     11396           
  Branches      1722      1722           
=========================================
  Hits         11396     11396

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 585ca92...6366726. Read the comment docs.

jgerigmeyer
jgerigmeyer approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jgerigmeyer jgerigmeyer merged commit 472026e into main May 5, 2022
@jgerigmeyer jgerigmeyer deleted the hotfix-storybook-deploy branch May 5, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgerigmeyer jgerigmeyer jgerigmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerivas @jgerigmeyer