Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flutter 3.29.0 #412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flutter 3.29.0 #412

wants to merge 1 commit into from
+4 −2

Conversation

shovelmn12
Copy link

No description provided.

@shovelmn12 shovelmn12 mentioned this pull request Feb 13, 2025
Open
1 task
@msayed-net
Copy link

it's urgent

@shovelmn12
Copy link
Author

@DennisAlund ...

@wayupdev
Copy link

temporary fix :

facebook_app_events:
git:
url: https://github.com/oddbit/flutter_facebook_app_events/
ref: e5bab0a

@JutoleOfficial
Copy link

hurry up pls

@trueAtom
Copy link

matiasmelendi
matiasmelendi approved these changes Feb 20, 2025
View reviewed changes
Copy link

@matiasmelendi matiasmelendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matiasmelendi
Copy link

@wwnOddbit @DennisAlund any chance you can merge this and release a new version?

@wwnOddbit
Copy link
Contributor

wwnOddbit commented Feb 21, 2025 •
edited
Loading

Thank you for the contributions.

Will this cause any breaking changes on older flutter versions?

Which flutter versions have this PR been tested on? Pass or fail?

@wwnOddbit wwnOddbit mentioned this pull request Feb 21, 2025
Open
@shovelmn12
Copy link
Author

@wwnOddbit I tested it only on 3.29

@nikb7
Copy link

nikb7 commented Feb 24, 2025

V1 embedding was deprecated in Flutter version 1.22
Reference - https://docs.flutter.dev/release/breaking-changes/android-v1-embedding-create-deprecation
It is a breaking change, but shouldn't have any impact on anyone who is using fluter above 1.22

@danbeechbloom
Copy link

Can we get this merged & released? it's blocking a lot of us

@sahilasopa
Copy link

Can we please merge this ASAP

@MaciejCaputa
Copy link

Hi, can we get this merged as it fails our build for android?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueAtom trueAtom trueAtom approved these changes

@JockerGG JockerGG JockerGG approved these changes

@matiasmelendi matiasmelendi matiasmelendi approved these changes

@msayed-net msayed-net msayed-net approved these changes

@p-karcz p-karcz p-karcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.