Updating github actions

oddbit · May 22, 2024 · 5dd2a83 · 5dd2a83
1 parent ead2d3c
commit 5dd2a83
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -30,7 +30,7 @@ jobs:
             ./hosting/.next/cache/
 
       - name: Build application
-        run: npm ci && npm run build
+        run: npm ci && npm install && npm run build
         working-directory: ./hosting
 
       - name: Upload build artifact
@@ -68,5 +68,5 @@ jobs:
         with:
           repoToken: ${{ secrets.GITHUB_TOKEN }}
           firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_TANAM_TESTING }}
-          channelId: live
           projectId: tanam-testing
+          channelId: live
diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -6,6 +6,7 @@ permissions:
   pull-requests: write
 jobs:
   build:
+    name: Build
     if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
     runs-on: ubuntu-latest
     steps:
@@ -32,7 +33,7 @@ jobs:
             ./hosting/.next/cache/
 
       - name: Build application
-        run: npm ci && npm run build
+        run: npm ci && npm install && npm run build
         working-directory: ./hosting
 
       - name: Upload build artifact
@@ -43,6 +44,8 @@ jobs:
           retention-days: 2
 
   deploy:
+    name: Deploy preview
+    if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -71,3 +74,4 @@ jobs:
           repoToken: ${{ secrets.GITHUB_TOKEN }}
           firebaseServiceAccount: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_TANAM_TESTING }}
           projectId: tanam-testing
+          expires: 7d