Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update backpack images width #3144

Merged
merged 1 commit into from
Jan 20, 2024
Merged

update backpack images width #3144

merged 1 commit into from
Jan 20, 2024

Conversation

Argn0
Copy link
Contributor

@Argn0 Argn0 commented Jan 20, 2024

forgot backpack images

@Argn0
Copy link
Contributor Author

Argn0 commented Jan 20, 2024 •
edited
Loading

Also it seems like ublock origin on Firefox severely slows down image loading times. Maybe it's because we're using the <object> tag?

@Argn0
Copy link
Contributor Author

Argn0 commented Jan 20, 2024

But do we even want to "support" adblock?

@howardchung howardchung merged commit fdd0e7b into master Jan 20, 2024
5 checks passed
@builder-247
Copy link
Member

This breaks the backpack item hover image dimensions

@howardchung howardchung mentioned this pull request Feb 1, 2024
Merged
@builder-247 builder-247 mentioned this pull request Feb 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Argn0 @builder-247 @howardchung