-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/osmnx import #64
Fix/osmnx import #64
Conversation
So this does not fix issue #48? Then it should not say so. Can you instead describe the issue you are solving with this PR? Can be in the first comment of this PR, but would be very helpful! |
This PR was indendet to do so, and it is not finshed yet ;-) However, I see your point. It makes sense to use a separate PR for that. I will update the PR description. |
the https://github.com/gboeing/osmnx/blob/master/CHANGELOG.md#0130-2020-05-25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general questions and comments on the osmnx import
Please ignore this comment. |
Okay, I fixed the issues regarding the not-running osmnx-import example, which means an update according to the actual osmnx version (0.16.1). I added this version requirement to the The other issues (like #48) of the osmnx import are not solved with this PR. |
@jnnr Since this branch is for review for more than 4 months now ;-) and it contains only small fixes by updating the API of the osmnx package, I would merge this branch if I don't hear anything by the end of next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully.
The osmnx_import example is not running.
On thing is that there was a wrong attribute name
distance
insteaddist
.The other issue, I don't know, I commented the lines. The principal import works now, however, likely not properly at the current state.
Could you have a look at it @jnnr ?