Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit book metadata #19

Merged
merged 12 commits into from
Feb 26, 2014
Merged

Edit book metadata #19

merged 12 commits into from
Feb 26, 2014

Conversation

TomWoodward
Copy link
Member

this is an extension of #18

and follows issue: oerpub/github-bookeditor#156

@kathi-fletcher
Copy link
Member

OK -- This needs master merged in before I can test it.

@kathi-fletcher
Copy link
Member

OK: I have done initial testing, just on the icon behavior and have put the issues that remain in a comment here: oerpub/github-bookeditor#156

I think we could live with the menu behavior (click to show) for now, and it might turn out finicky, so lets do it as a second stage.

@kathi-fletcher
Copy link
Member

  • Fixed stuff in New TOC and Shelf icons for consistency, efficiency, and metadata editing github-bookeditor#156 other than the hover behavior
  • In the editing dialog, change "Close" to "Close without saving" and add "Close and save".
  • In the cancel message that comes up, it is critical to not have the crazy double negative "I am canceling my cancel.".
  • Change the message to say "Are you sure you want to close without saving?", to make it completely clear what the "Cancel" message refers to.

There are some other bugs that Max and I have found, but I think we should get this stuff ready, merge, and then treat those as bugs.

@TomWoodward TomWoodward mentioned this pull request Feb 25, 2014
@kathi-fletcher
Copy link
Member

OK -- I found one major bug and made an issue for it. (Whole editor reloads if you click on the -> of an already opened module.

And then one book division opening scneario didn't work. I put that on the issue - oerpub/github-bookeditor#156 .

Will merge now so we can move forward.

kathi-fletcher added a commit that referenced this pull request Feb 26, 2014
@kathi-fletcher kathi-fletcher merged commit 08e40ea into master Feb 26, 2014
@kathi-fletcher kathi-fletcher deleted the edit-book-metadata branch February 26, 2014 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants