Skip to content

Commit

Permalink
revert 0.42.2 change
Browse files Browse the repository at this point in the history
  • Loading branch information
oetiker committed Jan 30, 2023
1 parent 31a341d commit 4d8a108
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
7 changes: 7 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
0.42.5 2023-01-30 18:59:37 +0100 Tobias Oetiker <[email protected]>

- revert 0.42.2 do NOT catch instanciation errors as this will
remove the ability to detect problems up the call stack
the error fixed in 0.42.2 must be fixed by catching the exception
further up the chain ...

0.42.4 2022-10-25 16:52:58 +0200 Tobias Oetiker <[email protected]>

- Fix broken qxObjectIds for Auto.js form elements
Expand Down
2 changes: 1 addition & 1 deletion lib/CallBackery.pm
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ use CallBackery::Database;
use CallBackery::User;


our $VERSION = '0.42.4';
our $VERSION = '0.42.5';


=head2 config
Expand Down
9 changes: 2 additions & 7 deletions lib/CallBackery/Controller/RpcService.pm
Original file line number Diff line number Diff line change
Expand Up @@ -253,13 +253,8 @@ async sub instantiatePlugin_p {
my $name = shift;
my $args = shift;
my $user = $self->user;
my $plugin;
try {
$plugin = await $self->config->instantiatePlugin_p($name,$user,$args);
$plugin->log($self->log);
} catch($error) {
$self->log->warn($error);
}
my $plugin = await $self->config->instantiatePlugin_p($name,$user,$args);
$plugin->log($self->log);
return $plugin;
}

Expand Down

0 comments on commit 4d8a108

Please sign in to comment.