Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu buttons #236

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Fix menu buttons #236

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f535443
Make foreach function calls consistent
zaucker Feb 15, 2024
2c7ace5
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Feb 15, 2024
26612ce
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Feb 16, 2024
ea7d2c7
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Feb 20, 2024
d9c2a0e
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Feb 20, 2024
f52e8cf
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Feb 20, 2024
2e2fc0f
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Feb 27, 2024
006c810
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Aug 6, 2024
195a8d9
Merge branch 'master' of github.com:oetiker/callbackery
zaucker Sep 19, 2024
f0c8ca4
Filter menu button properties for Card forms
zaucker Sep 19, 2024
da87413
Merge branch 'master' into FixMenuButtons
oetiker Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
- filter menuButtonProperties

0.50.1 2024-08-30 12:27:22 +0200 Tobias Oetiker <[email protected]>

- show a popup before reloading the page
Expand Down
7 changes: 5 additions & 2 deletions lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/plugin/Action.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,12 @@ qx.Class.define("callbackery.ui.plugin.Action", {
}
}
if (mbs) {
mmButton.set(mbs);
let mbsFiltered = Object.fromEntries(
['visibility', 'enabled', 'label', 'icon'].filter(key => key in mbs).map(key => [key, mbs[key]])
);
mmButton.set(mbsFiltered);
if (btCfg.key) {
this._menuButtonSetMap[btCfg.key] = mbs;
this._menuButtonSetMap[btCfg.key] = mbsFiltered;
}
}

Expand Down
Loading