Skip to content

Commit

Permalink
RISC-V: Add RV32E support.
Browse files Browse the repository at this point in the history
	Kito Cheng <[email protected]>
	Monk Chiang  <[email protected]>

	gcc/
	* common/config/riscv/riscv-common.c (riscv_parse_arch_string):
	Add support to parse rv32e*.  Clear MASK_RVE for rv32i and rv64i.
	* config.gcc (riscv*-*-*): Add support for rv32e* and ilp32e.
	* config/riscv/riscv-c.c (riscv_cpu_cpp_builtins): Define
	__riscv_32e when TARGET_RVE.  Handle ABI_ILP32E as soft-float ABI.
	* config/riscv/riscv-opts.h (riscv_abi_type): Add ABI_ILP32E.
	* config/riscv/riscv.c (riscv_compute_frame_info): When TARGET_RVE,
	compute save_libcall_adjustment properly.
	(riscv_option_override): Call error if TARGET_RVE and not ABI_ILP32E.
	(riscv_conditional_register_usage): Handle TARGET_RVE and ABI_ILP32E.
	* config/riscv/riscv.h (UNITS_PER_FP_ARG): Handle ABI_ILP32E.
	(STACK_BOUNDARY, ABI_STACK_BOUNDARY): Handle TARGET_RVE.
	(GP_REG_LAST, MAX_ARGS_IN_REGISTERS): Likewise.
	(ABI_SPEC): Handle mabi=ilp32e.
	* config/riscv/riscv.opt (abi_type): Add ABI_ILP32E.
	(RVE): Add RVE mask.
	* doc/invoke.texi (RISC-V options) <-mabi>: Add ilp32e info.
	<-march>: Add rv32e as an example.

	gcc/testsuite/
	* gcc.dg/stack-usage-1.c: Add support for rv32e.

	libgcc/
	* config/riscv/save-restore.S: Add support for rv32e.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@260384 138bc75d-0d04-0410-961f-82ee72b054a4
  • Loading branch information
wilson authored and kito-cheng committed Jul 27, 2018
1 parent e89f9f8 commit d2f7c2e
Show file tree
Hide file tree
Showing 13 changed files with 166 additions and 17 deletions.
23 changes: 23 additions & 0 deletions gcc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,26 @@
2018-05-18 Kito Cheng <[email protected]>
Monk Chiang <[email protected]>
Jim Wilson <[email protected]>

* common/config/riscv/riscv-common.c (riscv_parse_arch_string):
Add support to parse rv32e*. Clear MASK_RVE for rv32i and rv64i.
* config.gcc (riscv*-*-*): Add support for rv32e* and ilp32e.
* config/riscv/riscv-c.c (riscv_cpu_cpp_builtins): Define
__riscv_32e when TARGET_RVE. Handle ABI_ILP32E as soft-float ABI.
* config/riscv/riscv-opts.h (riscv_abi_type): Add ABI_ILP32E.
* config/riscv/riscv.c (riscv_compute_frame_info): When TARGET_RVE,
compute save_libcall_adjustment properly.
(riscv_option_override): Call error if TARGET_RVE and not ABI_ILP32E.
(riscv_conditional_register_usage): Handle TARGET_RVE and ABI_ILP32E.
* config/riscv/riscv.h (UNITS_PER_FP_ARG): Handle ABI_ILP32E.
(STACK_BOUNDARY, ABI_STACK_BOUNDARY): Handle TARGET_RVE.
(GP_REG_LAST, MAX_ARGS_IN_REGISTERS): Likewise.
(ABI_SPEC): Handle mabi=ilp32e.
* config/riscv/riscv.opt (abi_type): Add ABI_ILP32E.
(RVE): Add RVE mask.
* doc/invoke.texi (RISC-V options) <-mabi>: Add ilp32e info.
<-march>: Add rv32e as an example.

2018-05-17 Jim Wilson <[email protected]>

* expr.c (do_tablejump): When converting index to Pmode, if we have a
Expand Down
29 changes: 28 additions & 1 deletion gcc/common/config/riscv/riscv-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ along with GCC; see the file COPYING3. If not see
#include "flags.h"
#include "diagnostic-core.h"

/* Parse a RISC-V ISA string into an option mask. */
/* Parse a RISC-V ISA string into an option mask. Must clear or set all arch
dependent mask bits, in case more than one -march string is passed. */

static void
riscv_parse_arch_string (const char *isa, int *flags, location_t loc)
Expand All @@ -48,6 +49,8 @@ riscv_parse_arch_string (const char *isa, int *flags, location_t loc)
{
p++;

*flags &= ~MASK_RVE;

*flags |= MASK_MUL;
*flags |= MASK_ATOMIC;
*flags |= MASK_HARD_FLOAT;
Expand All @@ -57,6 +60,8 @@ riscv_parse_arch_string (const char *isa, int *flags, location_t loc)
{
p++;

*flags &= ~MASK_RVE;

*flags &= ~MASK_MUL;
if (*p == 'm')
*flags |= MASK_MUL, p++;
Expand All @@ -77,6 +82,28 @@ riscv_parse_arch_string (const char *isa, int *flags, location_t loc)
}
}
}
else if (*p == 'e')
{
p++;

*flags |= MASK_RVE;

if (*flags & MASK_64BIT)
{
error ("RV64E is not a valid base ISA");
return;
}

*flags &= ~MASK_MUL;
if (*p == 'm')
*flags |= MASK_MUL, p++;

*flags &= ~MASK_ATOMIC;
if (*p == 'a')
*flags |= MASK_ATOMIC, p++;

*flags &= ~(MASK_HARD_FLOAT | MASK_DOUBLE_FLOAT);
}
else
{
error_at (loc, "-march=%s: invalid ISA string", isa);
Expand Down
10 changes: 6 additions & 4 deletions gcc/config.gcc
Original file line number Diff line number Diff line change
Expand Up @@ -4080,19 +4080,20 @@ case "${target}" in

# Infer arch from --with-arch, --target, and --with-abi.
case "${with_arch}" in
rv32i* | rv32g* | rv64i* | rv64g*)
rv32e* | rv32i* | rv32g* | rv64i* | rv64g*)
# OK.
;;
"")
# Infer XLEN, but otherwise assume GC.
case "${with_abi}" in
ilp32e) with_arch="rv32e" ;;
ilp32 | ilp32f | ilp32d) with_arch="rv32gc" ;;
lp64 | lp64f | lp64d) with_arch="rv64gc" ;;
*) with_arch="rv${xlen}gc" ;;
esac
;;
*)
echo "--with-arch=${with_arch} is not supported. The argument must begin with rv32i, rv32g, rv64i, or rv64g." 1>&2
echo "--with-arch=${with_arch} is not supported. The argument must begin with rv32e, rv32i, rv32g, rv64i, or rv64g." 1>&2
exit 1
;;
esac
Expand All @@ -4101,11 +4102,12 @@ case "${target}" in
# pick a default based on the ISA, preferring soft-float
# unless the D extension is present.
case "${with_abi}" in
ilp32 | ilp32f | ilp32d | lp64 | lp64f | lp64d)
ilp32 | ilp32e | ilp32f | ilp32d | lp64 | lp64f | lp64d)
;;
"")
case "${with_arch}" in
rv32*d* | rv32g*) with_abi=ilp32d ;;
rv32e*) with_abi=ilp32e ;;
rv32*) with_abi=ilp32 ;;
rv64*d* | rv64g*) with_abi=lp64d ;;
rv64*) with_abi=lp64 ;;
Expand All @@ -4119,7 +4121,7 @@ case "${target}" in

# Make sure ABI and ISA are compatible.
case "${with_abi},${with_arch}" in
ilp32,rv32* \
ilp32,rv32* | ilp32e,rv32e* \
| ilp32f,rv32*f* | ilp32f,rv32g* \
| ilp32d,rv32*d* | ilp32d,rv32g* \
| lp64,rv64* \
Expand Down
4 changes: 4 additions & 0 deletions gcc/config/riscv/riscv-c.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile)
if (TARGET_RVC)
builtin_define ("__riscv_compressed");

if (TARGET_RVE)
builtin_define ("__riscv_32e");

if (TARGET_ATOMIC)
builtin_define ("__riscv_atomic");

Expand All @@ -62,6 +65,7 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile)
switch (riscv_abi)
{
case ABI_ILP32:
case ABI_ILP32E:
case ABI_LP64:
builtin_define ("__riscv_float_abi_soft");
break;
Expand Down
1 change: 1 addition & 0 deletions gcc/config/riscv/riscv-opts.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ along with GCC; see the file COPYING3. If not see

enum riscv_abi_type {
ABI_ILP32,
ABI_ILP32E,
ABI_ILP32F,
ABI_ILP32D,
ABI_LP64,
Expand Down
25 changes: 24 additions & 1 deletion gcc/config/riscv/riscv.c
Original file line number Diff line number Diff line change
Expand Up @@ -3334,7 +3334,14 @@ riscv_compute_frame_info (void)

/* Only use save/restore routines if they don't alter the stack size. */
if (RISCV_STACK_ALIGN (num_save_restore * UNITS_PER_WORD) == x_save_size)
frame->save_libcall_adjustment = x_save_size;
{
/* Libcall saves/restores 3 registers at once, so we need to
allocate 12 bytes for callee-saved register. */
if (TARGET_RVE)
x_save_size = 3 * UNITS_PER_WORD;

frame->save_libcall_adjustment = x_save_size;
}

offset += x_save_size;
}
Expand Down Expand Up @@ -4147,6 +4154,9 @@ riscv_option_override (void)
error ("requested ABI requires -march to subsume the %qc extension",
UNITS_PER_FP_ARG > 8 ? 'Q' : (UNITS_PER_FP_ARG > 4 ? 'D' : 'F'));

if (TARGET_RVE && riscv_abi != ABI_ILP32E)
error ("rv32e requires ilp32e ABI");

/* We do not yet support ILP32 on RV64. */
if (BITS_PER_WORD != POINTER_SIZE)
error ("ABI requires -march=rv%d", POINTER_SIZE);
Expand All @@ -4171,6 +4181,19 @@ riscv_option_override (void)
static void
riscv_conditional_register_usage (void)
{
/* We have only x0~x15 on RV32E. */
if (TARGET_RVE)
{
for (int r = 16; r <= 31; r++)
fixed_regs[r] = 1;
}

if (riscv_abi == ABI_ILP32E)
{
for (int r = 16; r <= 31; r++)
call_used_regs[r] = 1;
}

if (!TARGET_HARD_FLOAT)
{
for (int regno = FP_REG_FIRST; regno <= FP_REG_LAST; regno++)
Expand Down
17 changes: 10 additions & 7 deletions gcc/config/riscv/riscv.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,11 @@ along with GCC; see the file COPYING3. If not see
#define UNITS_PER_FP_REG (TARGET_DOUBLE_FLOAT ? 8 : 4)

/* The largest type that can be passed in floating-point registers. */
#define UNITS_PER_FP_ARG \
(riscv_abi == ABI_ILP32 || riscv_abi == ABI_LP64 ? 0 : \
riscv_abi == ABI_ILP32F || riscv_abi == ABI_LP64F ? 4 : 8) \
#define UNITS_PER_FP_ARG \
((riscv_abi == ABI_ILP32 || riscv_abi == ABI_ILP32E \
|| riscv_abi == ABI_LP64) \
? 0 \
: ((riscv_abi == ABI_ILP32F || riscv_abi == ABI_LP64F) ? 4 : 8))

/* Set the sizes of the core types. */
#define SHORT_TYPE_SIZE 16
Expand All @@ -124,10 +126,10 @@ along with GCC; see the file COPYING3. If not see
#define FUNCTION_BOUNDARY (TARGET_RVC ? 16 : 32)

/* The smallest supported stack boundary the calling convention supports. */
#define STACK_BOUNDARY (2 * BITS_PER_WORD)
#define STACK_BOUNDARY (TARGET_RVE ? BITS_PER_WORD : 2 * BITS_PER_WORD)

/* The ABI stack alignment. */
#define ABI_STACK_BOUNDARY 128
#define ABI_STACK_BOUNDARY (TARGET_RVE ? BITS_PER_WORD : 128)

/* There is no point aligning anything to a rounder boundary than this. */
#define BIGGEST_ALIGNMENT 128
Expand Down Expand Up @@ -260,7 +262,7 @@ along with GCC; see the file COPYING3. If not see
/* Internal macros to classify an ISA register's type. */

#define GP_REG_FIRST 0
#define GP_REG_LAST 31
#define GP_REG_LAST (TARGET_RVE ? 15 : 31)
#define GP_REG_NUM (GP_REG_LAST - GP_REG_FIRST + 1)

#define FP_REG_FIRST 32
Expand Down Expand Up @@ -490,7 +492,7 @@ enum reg_class
#define GP_RETURN GP_ARG_FIRST
#define FP_RETURN (UNITS_PER_FP_ARG == 0 ? GP_RETURN : FP_ARG_FIRST)

#define MAX_ARGS_IN_REGISTERS 8
#define MAX_ARGS_IN_REGISTERS (TARGET_RVE ? 6 : 8)

/* Symbolic macros for the first/last argument registers. */

Expand Down Expand Up @@ -870,6 +872,7 @@ extern unsigned riscv_stack_boundary;

#define ABI_SPEC \
"%{mabi=ilp32:ilp32}" \
"%{mabi=ilp32e:ilp32e}" \
"%{mabi=ilp32f:ilp32f}" \
"%{mabi=ilp32d:ilp32d}" \
"%{mabi=lp64:lp64}" \
Expand Down
5 changes: 5 additions & 0 deletions gcc/config/riscv/riscv.opt
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ Supported ABIs (for use with the -mabi= option):
EnumValue
Enum(abi_type) String(ilp32) Value(ABI_ILP32)

EnumValue
Enum(abi_type) String(ilp32e) Value(ABI_ILP32E)

EnumValue
Enum(abi_type) String(ilp32f) Value(ABI_ILP32F)

Expand Down Expand Up @@ -122,3 +125,5 @@ Mask(HARD_FLOAT)
Mask(DOUBLE_FLOAT)

Mask(RVC)

Mask(RVE)
7 changes: 5 additions & 2 deletions gcc/doc/invoke.texi
Original file line number Diff line number Diff line change
Expand Up @@ -23054,7 +23054,9 @@ conventions are: @samp{ilp32}, @samp{ilp32f}, @samp{ilp32d}, @samp{lp64},
@samp{lp64f}, and @samp{lp64d}. Some calling conventions are impossible to
implement on some ISAs: for example, @samp{-march=rv32if -mabi=ilp32d} is
invalid because the ABI requires 64-bit values be passed in F registers, but F
registers are only 32 bits wide.
registers are only 32 bits wide. There is also the @samp{ilp32e} ABI that can
only be used with the @samp{rv32e} architecture. This ABI is not well
specified at present, and is subject to change.

@item -mfdiv
@itemx -mno-fdiv
Expand All @@ -23073,7 +23075,8 @@ these instructions.
@item -march=@var{ISA-string}
@opindex march
Generate code for given RISC-V ISA (e.g.@ @samp{rv64im}). ISA strings must be
lower-case. Examples include @samp{rv64i}, @samp{rv32g}, and @samp{rv32imaf}.
lower-case. Examples include @samp{rv64i}, @samp{rv32g}, @samp{rv32e}, and
@samp{rv32imaf}.

@item -mtune=@var{processor-string}
@opindex mtune
Expand Down
4 changes: 4 additions & 0 deletions gcc/testsuite/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2018-05-18 Kito Cheng <[email protected]>

* gcc.dg/stack-usage-1.c: Add support for rv32e.

2018-05-17 Jim Wilson <[email protected]>

* gcc.target/riscv/switch-qi.c: New.
Expand Down
6 changes: 5 additions & 1 deletion gcc/testsuite/gcc.dg/stack-usage-1.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@
# define SIZE 240
# endif
#elif defined (__riscv)
# define SIZE 240
# if defined (__riscv_32e)
# define SIZE 252
# else
# define SIZE 240
# endif
#elif defined (__AVR__)
#if defined (__AVR_3_BYTE_PC__ )
# define SIZE 251 /* 256 - 2 bytes for Y - 3 bytes for return address */
Expand Down
6 changes: 6 additions & 0 deletions libgcc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2018-05-18 Kito Cheng <[email protected]>
Monk Chiang <[email protected]>
Jim Wilson <[email protected]>

* config/riscv/save-restore.S: Add support for rv32e.

2018-07-26 Release Manager

* GCC 8.2.0 released.
Expand Down
46 changes: 45 additions & 1 deletion libgcc/config/riscv/save-restore.S
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,48 @@ FUNC_END (__riscv_restore_0)

#else

#ifdef __riscv_32e
FUNC_BEGIN(__riscv_save_2)
FUNC_BEGIN(__riscv_save_1)
FUNC_BEGIN(__riscv_save_0)
.cfi_startproc
# __riscv_save_* routine use t0/x5 as return address
.cfi_return_column 5
addi sp, sp, -12
.cfi_def_cfa_offset 12
sw s1, 0(sp)
.cfi_offset 9, -12
sw s0, 4(sp)
.cfi_offset 8, -8
sw ra, 8(sp)
.cfi_offset 1, 0
jr t0
.cfi_endproc
FUNC_END(__riscv_save_2)
FUNC_END(__riscv_save_1)
FUNC_END(__riscv_save_0)

FUNC_BEGIN(__riscv_restore_2)
FUNC_BEGIN(__riscv_restore_1)
FUNC_BEGIN(__riscv_restore_0)
.cfi_startproc
.cfi_def_cfa_offset 14
lw s1, 0(sp)
.cfi_restore 9
lw s0, 4(sp)
.cfi_restore 8
lw ra, 8(sp)
.cfi_restore 1
addi sp, sp, 12
.cfi_def_cfa_offset 0
ret
.cfi_endproc
FUNC_END(__riscv_restore_2)
FUNC_END(__riscv_restore_1)
FUNC_END(__riscv_restore_0)

#else

FUNC_BEGIN (__riscv_save_12)
.cfi_startproc
# __riscv_save_* routine use t0/x5 as return address
Expand Down Expand Up @@ -486,4 +528,6 @@ FUNC_END (__riscv_restore_2)
FUNC_END (__riscv_restore_1)
FUNC_END (__riscv_restore_0)

#endif
#endif /* __riscv_32e */

#endif /* __riscv_xlen == 64 */

0 comments on commit d2f7c2e

Please sign in to comment.