Fix error for no bench (#10)

Fix error message for when signature or nps is missing
official-monty · Aug 16, 2024 · ee0af92 · ee0af92
1 parent 4fcd3f2
commit ee0af92
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/server/montytest/api.py b/server/montytest/api.py
@@ -34,7 +34,7 @@
 according to the route/URL mapping defined in `__init__.py`.
 """
 
-WORKER_VERSION = 7
+WORKER_VERSION = 8
 
 
 @exception_view_config(HTTPException)

diff --git a/worker/games.py b/worker/games.py
@@ -406,13 +406,14 @@ def verify_signature(engine, signature, active_cores):
     bench_nps = 0.0
 
     for sig, nps in results:
-        bench_nps += nps
 
-        if sig is None or bench_nps is None:
+        if sig is None or nps is None:
             raise RunException(
                 "Unable to parse bench output of {}".format(os.path.basename(engine))
             )
 
+        bench_nps += nps
+
         if int(sig) != int(signature):
             message = "Wrong bench in {}, user expected: {} but worker got: {}".format(
                 os.path.basename(engine),

diff --git a/worker/sri.txt b/worker/sri.txt
@@ -1 +1 @@
-{"__version": 7, "updater.py": "gSJX/HbsPwsZnUZaFbAgF0zwWPWXv+LEw9jBhJkxFOrCH9CZS0+4U4nE2fJdeNze", "worker.py": "YlLPByFLklFmr7+O9dN4lBb53bBd7VwOL9huIOCwdbU61H+gQ5nbLvPstux9q5eV", "games.py": "t8zqbxWzFH9akr8pkhkUKbQHxJtg5tVfCS/xx9CeFucAcLQrgHRWo2Tt7TUYwOQf"}
+{"__version": 8, "updater.py": "gSJX/HbsPwsZnUZaFbAgF0zwWPWXv+LEw9jBhJkxFOrCH9CZS0+4U4nE2fJdeNze", "worker.py": "rFlovYBYNuqCmEJCNV1JRl1MmgHxEJLf/56xpVq39OSwy2HtxDwEhnwLz2V9EfNL", "games.py": "Gy3Y9/DisuptYUu/zV4ZViHUU/jSJ2a5WGSPyjP9hTRxDqV47xir4RBWhkh7IIbi"}
diff --git a/worker/worker.py b/worker/worker.py
@@ -65,7 +65,7 @@
 MIN_CARGO_MAJOR = 1
 MIN_CARGO_MINOR = 77
 
-WORKER_VERSION = 7
+WORKER_VERSION = 8
 FILE_LIST = ["updater.py", "worker.py", "games.py"]
 HTTP_TIMEOUT = 30.0
 INITIAL_RETRY_TIME = 15.0
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		{"__version": 7, "updater.py": "gSJX/HbsPwsZnUZaFbAgF0zwWPWXv+LEw9jBhJkxFOrCH9CZS0+4U4nE2fJdeNze", "worker.py": "YlLPByFLklFmr7+O9dN4lBb53bBd7VwOL9huIOCwdbU61H+gQ5nbLvPstux9q5eV", "games.py": "t8zqbxWzFH9akr8pkhkUKbQHxJtg5tVfCS/xx9CeFucAcLQrgHRWo2Tt7TUYwOQf"}
		{"__version": 8, "updater.py": "gSJX/HbsPwsZnUZaFbAgF0zwWPWXv+LEw9jBhJkxFOrCH9CZS0+4U4nE2fJdeNze", "worker.py": "rFlovYBYNuqCmEJCNV1JRl1MmgHxEJLf/56xpVq39OSwy2HtxDwEhnwLz2V9EfNL", "games.py": "Gy3Y9/DisuptYUu/zV4ZViHUU/jSJ2a5WGSPyjP9hTRxDqV47xir4RBWhkh7IIbi"}