Put SPSA code in a separate file. #2262
Merged
+190
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppigazzini
added
server
Mar 08 10:08:45 dfts-0 pserve[8505]: File "/home/usr00/fishtest/server/fishtest/__init__.py", line 50, in main
Mar 08 10:08:45 dfts-0 pserve[8505]: rundb = RunDb(port=port, is_primary_instance=is_primary_instance)
Mar 08 10:08:45 dfts-0 pserve[8505]: File "/home/usr00/fishtest/server/fishtest/rundb.py", line 108, in __init__
Mar 08 10:08:45 dfts-0 pserve[8505]: self.spsa_handler = fishtest.spsa_handler.SPSAHandler(self)
Mar 08 10:08:45 dfts-0 pserve[8505]: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
Mar 08 10:08:45 dfts-0 pserve[8505]: File "/home/usr00/fishtest/server/fishtest/spsa_handler.py", line 83, in __init__
Mar 08 10:08:45 dfts-0 pserve[8505]: self.buffer = rundb.buffer
Mar 08 10:08:45 dfts-0 pserve[8505]: ^^^^^^^^^^^^
Mar 08 10:08:45 dfts-0 pserve[8505]: AttributeError: 'RunDb' object has no attribute 'buffer' |
|
Ok I see. A secondary instance does not have |
SPSA code related code is sprinkled at various places. It would be beneficial to put it in a single place. In this PR we move the SPSA code in rundb.py to a separate file. Other code will follow in the future. We submit this PR now because it is difficult to continuously rebase a PR that moves code.
|
Should be fixed. |
ppigazzini
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Looks good on DEV with a couple of SPSAs. PROD update in seconds, thank you @vdbergh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPSA code related code is sprinkled at various places. It would be beneficial to put it in a single place.
In this PR we move the SPSA code in rundb.py to a separate file. Other code will follow in the future. We submit this PR now because it is difficult to continuously rebase a PR that moves code.