Move the check for max number of channels limit into can_join so that…

… is applies everywhere instead of just one place
oftc · Jul 13, 2016 · 6e334f7 · 6e334f7
1 parent bf1fd8b
commit 6e334f7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/modules/core/m_join.c b/modules/core/m_join.c
@@ -179,15 +179,6 @@ m_join(struct Client *client_p, struct Client *source_p,
       continue;
     }
 
-    if ((dlink_list_length(&source_p->channel) >= ConfigChannel.max_chans_per_user) &&
-        (!IsOper(source_p) || (dlink_list_length(&source_p->channel) >=
-                               ConfigChannel.max_chans_per_user * 3)))
-    {
-      sendto_one(source_p, form_str(ERR_TOOMANYCHANNELS),
-                 me.name, source_p->name, chan);
-      break;
-    }
-
     if ((chptr = hash_find_channel(chan)) != NULL)
     {
       if (IsMember(source_p, chptr))
@@ -238,7 +229,10 @@ m_join(struct Client *client_p, struct Client *source_p,
     {
       sendto_one(source_p, form_str(i), me.name,
                  source_p->name, chptr->chname);
-      continue;
+      if(i == ERR_TOOMANYCHANNELS)
+          break;
+      else
+          continue;
     }
 
     if(i != 0 && IsGod(source_p) && MyClient(source_p))

diff --git a/src/channel.c b/src/channel.c
@@ -689,6 +689,12 @@ can_join(struct Client *source_p, struct Channel *chptr, const char *key)
   if(IsService(source_p))
     return 0;
 
+  if ((dlink_list_length(&source_p->channel) >= ConfigChannel.max_chans_per_user) &&
+       (!IsOper(source_p) || (dlink_list_length(&source_p->channel) >=
+                              ConfigChannel.max_chans_per_user * 3)))
+      return ERR_TOOMANYCHANNELS;
+
+
   if (is_banned(chptr, source_p))
     return ERR_BANNEDFROMCHAN;