Skip to content

Commit

Permalink
Fix build.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
ogghead committed Aug 31, 2024
1 parent a8b57d4 commit 6620086
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
run: ls -R
- name: pluginify it
run: |
spin pluginify --merge --release-url-base https://github.com/fermyon/spin-trigger-kinesis/releases/download/${{ env.RELEASE_VERSION }}/ >${{ env.PROGRAM_NAME }}.json
spin pluginify --merge --release-url-base https://github.com/ogghead/spin-trigger-kinesis/releases/download/${{ env.RELEASE_VERSION }}/ >${{ env.PROGRAM_NAME }}.json
- name: Display merged manifest
run: cat ${{ env.PROGRAM_NAME }}.json

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ There is no SDK for kinesis guest components. Use the `kinesis.wit` file to gen

Your handler can an error, but should otherwise not return anything.

**Note:** The trigger currently processes records using ShardIteratorType::Latest. This means that only records published after the app is running will be read.
**Note:** The trigger currently processes records using ShardIteratorType::Latest. This means that only records published after the app is spun up will be processed by the trigger.

**Note:** The trigger continues to poll shards while a handler is running. This means that records are not necessarily processed sequentially.

0 comments on commit 6620086

Please sign in to comment.