fix(test): fixed tests

ohcnetwork · Feb 27, 2024 · 4daf666 · 4daf666
1 parent c099f70
commit 4daf666
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 5 deletions.
diff --git a/care/facility/api/serializers/daily_round.py b/care/facility/api/serializers/daily_round.py
@@ -15,6 +15,7 @@
     COVID_CATEGORY_CHOICES,
     PatientRegistration,
 )
+from care.facility.models.base import covert_choice_dict
 from care.facility.models.bed import Bed
 from care.facility.models.daily_round import DailyRound
 from care.facility.models.notification import Notification
@@ -29,6 +30,8 @@
 from care.utils.queryset.facility import get_home_facility_queryset
 from config.serializers import ChoiceField
 
+SymptomChoiceDict = covert_choice_dict(SYMPTOM_CHOICES)
+
 
 class DailyRoundSerializer(serializers.ModelSerializer):
     id = serializers.CharField(source="external_id", read_only=True)
@@ -353,6 +356,17 @@ def validate(self, attrs):
                     {"temperature": ["This field value must be between 95 and 106."]}
                 )
 
+        if "additional_symptoms" in validated:
+            if SymptomChoiceDict["OTHERS"] in validated["additional_symptoms"]:
+                if "other_symptoms" not in validated:
+                    raise ValidationError(
+                        {
+                            "other_symptoms": [
+                                "This field is required if OTHERS is selected in Additional Symptoms."
+                            ]
+                        }
+                    )
+
         if "bed" in validated:
             external_id = validated.pop("bed")["external_id"]
             if external_id:

diff --git a/care/facility/tests/test_patient_daily_rounds_api.py b/care/facility/tests/test_patient_daily_rounds_api.py
@@ -14,11 +14,19 @@ def setUpTestData(cls) -> None:
         cls.district = cls.create_district(cls.state)
         cls.local_body = cls.create_local_body(cls.district)
         cls.super_user = cls.create_super_user("su", cls.district)
-        cls.facility = cls.create_facility(cls.super_user, cls.district, cls.local_body)
-        cls.user = cls.create_user("staff1", cls.district, home_facility=cls.facility)
-        cls.patient = cls.create_patient(district=cls.district, facility=cls.facility)
+        cls.facility = cls.create_facility(
+            cls.super_user, cls.district, cls.local_body
+        )
+        cls.user = cls.create_user(
+            "staff1", cls.district, home_facility=cls.facility
+        )
+        cls.patient = cls.create_patient(
+            district=cls.district, facility=cls.facility
+        )
         cls.asset_location = cls.create_asset_location(cls.facility)
-        cls.bed = cls.create_bed(facility=cls.facility, location=cls.asset_location)
+        cls.bed = cls.create_bed(
+            facility=cls.facility, location=cls.asset_location
+        )
         cls.consultation_without_bed = cls.create_consultation(
             facility=cls.facility, patient=cls.patient
         )
@@ -62,7 +70,8 @@ def test_action_in_log_update(
             id=self.consultation_with_bed.patient_id
         )
         self.assertEqual(
-            patient.action, PatientRegistration.ActionEnum.DISCHARGE_RECOMMENDED.value
+            patient.action,
+            PatientRegistration.ActionEnum.DISCHARGE_RECOMMENDED.value,
         )
 
     def test_log_update_without_bed(