save db queries :)

ohcnetwork · Aug 29, 2023 · f9e2865 · f9e2865
1 parent 61792fb
commit f9e2865
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/care/facility/api/serializers/prescription.py b/care/facility/api/serializers/prescription.py
@@ -1,12 +1,7 @@
 from django.shortcuts import get_object_or_404
 from rest_framework import serializers
 
-from care.facility.models import (
-    MedibaseMedicine,
-    MedicineAdministration,
-    PatientConsultation,
-    Prescription,
-)
+from care.facility.models import MedibaseMedicine, MedicineAdministration, Prescription
 from care.users.api.serializers.user import UserBaseMinimumSerializer
 
 
@@ -63,15 +58,10 @@ def validate(self, attrs):
             )
 
         if not self.instance:
-            consultation_obj = get_object_or_404(
-                PatientConsultation,
-                external_id=self.context["request"].parser_context["kwargs"][
-                    "consultation_external_id"
-                ],
-            )
-
             if Prescription.objects.filter(
-                consultation=consultation_obj,
+                consultation__external_id=self.context["request"].parser_context[
+                    "kwargs"
+                ]["consultation_external_id"],
                 medicine=attrs["medicine"],
                 discontinued=False,
             ).exists():